Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrates to monorepo #5

Merged
merged 4 commits into from
Jul 9, 2024
Merged

refactor: migrates to monorepo #5

merged 4 commits into from
Jul 9, 2024

Conversation

kevinhermawan
Copy link
Collaborator

@kevinhermawan kevinhermawan commented Jul 2, 2024 •
edited
Loading

This PR solves #2, #3, and #4

@kevinhermawan kevinhermawan requested a review from nicnocquee July 2, 2024 08:15
nico-hyperjump
nico-hyperjump requested changes Jul 3, 2024
View reviewed changes
Copy link

@nico-hyperjump nico-hyperjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the common practice is to put the library in the "packages" folder instead of "apps". In "apps" later we can put the example of using the two libs.

@kevinhermawan kevinhermawan merged commit dd46186 into main Jul 9, 2024
4 checks passed
@kevinhermawan kevinhermawan deleted the monorepo branch July 9, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nico-hyperjump nico-hyperjump nico-hyperjump requested changes

@nicnocquee nicnocquee Awaiting requested review from nicnocquee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinhermawan @nico-hyperjump @kevin-hyperjump